Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors #1784

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Dec 9, 2022

Description

This PR passes TLS min version and ciphersuites from the TLSSecurityProfile to the log collectors and the log file metric exporter.
Depends on corresponding PRs in vector and log-file-metric-exporter repos.

/cc @alanconway
/assign @jcantrill

Links

@openshift-ci openshift-ci bot requested a review from alanconway December 9, 2022 04:28
@syedriko syedriko changed the title LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors WIP: LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors Dec 9, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2022
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I take it this is prometheus and fluetnd part, vector is yet to come?

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 12, 2022
@syedriko
Copy link
Contributor Author

/lgtm

I take it this is prometheus and fluetnd part, vector is yet to come?

The prometheus listener in vector is very much there, the CLO changes are under internal/generator/vector and the corresponding vector changes are in ViaQ/vector#129.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2023
@syedriko
Copy link
Contributor Author

/retest

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@jcantrill jcantrill changed the title WIP: LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors Feb 27, 2023
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

@syedriko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 879c3b9 link true /test e2e
ci/prow/e2e-claim-aws 879c3b9 link false /test e2e-claim-aws
ci/prow/e2e-ocp-next 879c3b9 link false /test e2e-ocp-next
ci/prow/e2e-ocp-previous 879c3b9 link false /test e2e-ocp-previous
ci/prow/functional-target b070ee0 link false /test functional-target
ci/prow/e2e-ocp-target-minus-one b070ee0 link false /test e2e-ocp-target-minus-one

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit feb2a61 into openshift:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants