-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors #1784
LOG-3398: Apply TLSSecurityProfile settings to TLS listeners in log collectors #1784
Conversation
77554ba
to
879c3b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I take it this is prometheus and fluetnd part, vector is yet to come?
The prometheus listener in vector is very much there, the CLO changes are under internal/generator/vector and the corresponding vector changes are in ViaQ/vector#129. |
879c3b9
to
dc7a506
Compare
dc7a506
to
b070ee0
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway, jcantrill, syedriko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@syedriko: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
This PR passes TLS min version and ciphersuites from the TLSSecurityProfile to the log collectors and the log file metric exporter.
Depends on corresponding PRs in vector and log-file-metric-exporter repos.
/cc @alanconway
/assign @jcantrill
Links