OCPCLOUD-2680,OCPCLOUD-2860: Enable metadata syncing

[nrb]

This change contains two commits:

• Enable label syncing from Machines to Nodes. Maps to 🌱 Add --additional-sync-machine-labels to allow syncing additional labels to Nodes kubernetes-sigs/cluster-api#11650 and https://issues.redhat.com/browse/OCPCLOUD-2680
• Enable annotation syncing from Machines to Nodes. Maps to ✨ Sync machine annotations to nodes kubernetes-sigs/cluster-api#11813 & https://issues.redhat.com/browse/OCPCLOUD-2860

As of this writing, OCPCLOUD-2680 is merged upstream, but is not yet in a released version. It should be in v1.9.5 when that is out.

OCPCLOUD-2860 is not yet merged upstream. It is likely to be in v1.9.6, but might possibly merge early enough to get into v1.9.5.

If someone takes over this PR or has to split it up, you can get the same generated manifests with an updated version of CAPI with these commands (you'll need to include the updated Makefile and the two new kustomize files):

cd openshift
PROVIDER_VERSION=v1.9.4 make ocp-manifests

[openshift-ci-robot]

@nrb: This pull request references OCPCLOUD-2680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references OCPCLOUD-2860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This change contains two comments:

• Enable label syncing from Machines to Nodes. Maps to 🌱 Add --additional-sync-machine-labels to allow syncing additional labels to Nodes kubernetes-sigs/cluster-api#11650 and https://issues.redhat.com/browse/OCPCLOUD-2680
• Enable annotation syncing from Machines to Nodes. Maps to ✨ Sync machine annotations to nodes kubernetes-sigs/cluster-api#11813 & https://issues.redhat.com/browse/OCPCLOUD-2860

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nrb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@nrb: This pull request references OCPCLOUD-2680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references OCPCLOUD-2860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This change contains two commits:

• Enable label syncing from Machines to Nodes. Maps to 🌱 Add --additional-sync-machine-labels to allow syncing additional labels to Nodes kubernetes-sigs/cluster-api#11650 and https://issues.redhat.com/browse/OCPCLOUD-2680
• Enable annotation syncing from Machines to Nodes. Maps to ✨ Sync machine annotations to nodes kubernetes-sigs/cluster-api#11813 & https://issues.redhat.com/browse/OCPCLOUD-2860

As of this writing, OCPCLOUD-2680 is merged upstream, but is not yet in a released version. It should be in v1.9.5 when that is out.

OCPCLOUD-2860 is not yet merged upstream. It is likely to be in v1.9.6, but might possibly merge early enough to get into v1.9.5.

If someone takes over this PR, you can get the same generated manifests with an updated version of CAPI with these commands (you'll need to include the updated Makefile and the two new kustomize files):

cd openshift
PROVIDER_VERSION=v1.9.4 make ocp-manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@nrb: This pull request references OCPCLOUD-2680 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

This pull request references OCPCLOUD-2860 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This change contains two commits:

• Enable label syncing from Machines to Nodes. Maps to 🌱 Add --additional-sync-machine-labels to allow syncing additional labels to Nodes kubernetes-sigs/cluster-api#11650 and https://issues.redhat.com/browse/OCPCLOUD-2680
• Enable annotation syncing from Machines to Nodes. Maps to ✨ Sync machine annotations to nodes kubernetes-sigs/cluster-api#11813 & https://issues.redhat.com/browse/OCPCLOUD-2860

As of this writing, OCPCLOUD-2680 is merged upstream, but is not yet in a released version. It should be in v1.9.5 when that is out.

OCPCLOUD-2860 is not yet merged upstream. It is likely to be in v1.9.6, but might possibly merge early enough to get into v1.9.5.

If someone takes over this PR or has to split it up, you can get the same generated manifests with an updated version of CAPI with these commands (you'll need to include the updated Makefile and the two new kustomize files):

cd openshift
PROVIDER_VERSION=v1.9.4 make ocp-manifests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[nrb]

/hold

Since this requires some other PRs to merge and then a rebase, don't merge it quite yet.

[openshift-ci]

@nrb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	6e9a3cd	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview	6e9a3cd	link	true	/test e2e-aws-ovn-techpreview
ci/prow/regression-clusterinfra-aws-ipi-techpreview	6e9a3cd	link	false	/test regression-clusterinfra-aws-ipi-techpreview
ci/prow/e2e-gcp-capi-techpreview	6e9a3cd	link	true	/test e2e-gcp-capi-techpreview
ci/prow/e2e-openstack-capi-techpreview	6e9a3cd	link	true	/test e2e-openstack-capi-techpreview
ci/prow/e2e-aws-capi-techpreview	6e9a3cd	link	true	/test e2e-aws-capi-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.