ART-9021 get rid of auto in canonical_builders_from_upstream #669
Conversation
| @@ -627,23 +625,6 @@ def test_canonical_builders_enabled(self, release_schedule, mock_datetime): | |||
| self.img_dg.runtime.group_config.canonical_builders_from_upstream = True | |||
| self.assertEqual(False, self.img_dg._canonical_builders_enabled()) | |||
|
|
|||
| # canonical_builders_from_upstream = 'on' in image config (override) | |||
There was a problem hiding this comment.
This block should still apply, why removing it?
There was a problem hiding this comment.
the on and off also need to be replaced with true and false, pr updated to limit supported mode to [ True, False ]
| @@ -229,7 +229,7 @@ | |||
| "urls-": {}, | |||
| "canonical_builders_from_upstream": { | |||
| "description": "Assert our base images, or listen to upstream", | |||
| "enum": [true, false, "auto", "off", "no", "on", "yes"] | |||
There was a problem hiding this comment.
The code still handles on and off, so why deprecating these in the schema? If we do so, the code should only allow True or False
There was a problem hiding this comment.
the on and off also need to be replaced with true and false, let's limit the value to bool true and false
There was a problem hiding this comment.
Ok, so maybe we can use a boolean type instead?
| @@ -208,7 +208,7 @@ | |||
| "content-": {}, | |||
| "canonical_builders_from_upstream": { | |||
| "description": "Override the facility to adhere to upstream suggestions for base images", | |||
| "enum": [true, false, "auto", "off", "no", "on", "yes"] | |||
Ximinhan
added
the
tide/merge-method-squash
|
@Ximinhan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 6f5e6dd
into
openshift-eng:main
canonical_builders_from_upstream supported mode to limit to [ True, False ] remove the unused lib release_schedule.py