[v3.0.0] Deprecate OpenSearch DSL format #3367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
changed the title
seankao-az
force-pushed
the
deprecate-dsl
branch
from
d96e854 to
7de6452
Compare
This reverts commit e3157aa. Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
force-pushed
the
deprecate-dsl
branch
from
7de6452 to
48d512a
Compare
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
Signed-off-by: Sean Kao <seankao@amazon.com>
seankao-az
commented
Mar 3, 2025
| @@ -116,7 +126,7 @@ public static QueryAction create(Client client, QueryActionRequest request) | |||
| } else { | |||
| sqlExpr.accept(new TermFieldRewriter()); | |||
| // migrate aggregation to query planner framework. | |||
| if (shouldMigrateToQueryPlan(sqlExpr, request.getFormat())) { | |||
| if (!bypassMigrateToQueryPlan && shouldMigrateToQueryPlan(sqlExpr)) { | |||
There was a problem hiding this comment.
Previously some test cases use Format.JSON to bypass this check and get QueryAction for SELECT (either AggregationQueryAction or DefaultQueryAction). After removing Format.JSON, those test case wouldn't work without this flag.
seankao-az
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925 and
dai-chen
as code owners
seankao-az
requested review from
YANG-DB,
mengweieric,
Swiddis,
penghuo,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
Signed-off-by: Sean Kao <seankao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the OpenSearch DSL response format.
This PR focus only on deprecating the format, and will silent the affected legacy test cases. #3372 is created to track the task to decide which of the legacy tests are worth keeping and what to do with them.
Documentation website changes required:
possibly more
Related Issues
Resolves #3280
Check List
- [ ] New functionality includes testing.- [ ] API changes companion pull request created.--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.