-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3.0.0] Deprecate scroll API usage #3346
[v3.0.0] Deprecate scroll API usage #3346
Conversation
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
is there any todo item? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Rebase and merge conflict
This branch has conflicts that must be resolved
Signed-off-by: Tomoyuki MORITA <moritato@amazon.com>
No, I mean fixed tests in this PR. |
Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Could you double check no impact on JDBC/ODBC driver? I recall they depend on this feature.
Thanks, looks it depends on https://github.com/opensearch-project/sql-odbc/blob/578196bb16a96899cc8964886de77d751a5a3ec7/src/sqlodbc/odbcapi30.c#L152 |
Tested JDBC/ODBC driver to work with this change (PIT). |
Description
Related Issues
Resolves #3284
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.