Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.0.0] Deprecate scroll API usage #3346

Merged

Conversation

ykmr1224
Copy link
Collaborator

Description

  • Deprecate scroll API usage
  • plugins.sql.pagination.api config is deleted and default to PIT
  • Needed to fix tests in legacy since they didn't have PIT version

Related Issues

Resolves #3284

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@ykmr1224 ykmr1224 changed the title Deprecate scroll API usage [v3.0.0] Deprecate scroll API usage Feb 25, 2025
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
Signed-off-by: Tomoyuki Morita <moritato@amazon.com>
@penghuo
Copy link
Collaborator

penghuo commented Feb 25, 2025

Needed to fix tests in legacy since they didn't have PIT version

is there any todo item?

Copy link
Collaborator

@noCharger noCharger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Rebase and merge conflict

This branch has conflicts that must be resolved

Signed-off-by: Tomoyuki MORITA <moritato@amazon.com>
@ykmr1224
Copy link
Collaborator Author

Needed to fix tests in legacy since they didn't have PIT version

is there any todo item?

No, I mean fixed tests in this PR.

@ykmr1224
Copy link
Collaborator Author

Nit: Rebase and merge conflict

This branch has conflicts that must be resolved

Fixed.

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Could you double check no impact on JDBC/ODBC driver? I recall they depend on this feature.

@ykmr1224
Copy link
Collaborator Author

Thanks for the changes! Could you double check no impact on JDBC/ODBC driver? I recall they depend on this feature.

Thanks, looks it depends on https://github.com/opensearch-project/sql-odbc/blob/578196bb16a96899cc8964886de77d751a5a3ec7/src/sqlodbc/odbcapi30.c#L152
Filed an issue: opensearch-project/sql-odbc#84

@ykmr1224
Copy link
Collaborator Author

ykmr1224 commented Mar 3, 2025

Tested JDBC/ODBC driver to work with this change (PIT).

@ykmr1224 ykmr1224 merged commit 482c681 into opensearch-project:main Mar 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove plugins.sql.pagination.api, default to PIT, deprecated scroll API.
4 participants