Add option to use 50 percent memory as heap #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishabh Singh <sngri@amazon.com>
rishabh6788
requested review from
peterzhuamazon,
bbarani,
gaiksaya,
zelinh,
jordarlu,
prudhvigodithi and
Divyaasm
as code owners
gaiksaya
reviewed
Apr 21, 2023
README.md
Outdated
| @@ -58,7 +58,7 @@ In order to deploy both the stacks the user needs to provide a set of required a | |||
| | account (Optional) | string | User provided aws account | | |||
| | dataNodeStorage (Optional) | string | User provided ebs block storage size, defaults to 100Gb | | |||
| | mlNodeStorage (Optional) | string | User provided ebs block storage size, defaults to 100Gb | | |||
| | jvmHeapSize (Optional) | integer | User provided JVM heap memory size (integer) in Gb, defaults to 1Gb, e.g. `--context jvmHeapSize=2` to set heap to 2Gb | | |||
| | use50PercentHeap (Optional) | boolean | Boolean flag to use 50% of physical memory as heap. e.g., `--context use50PercentHeap=true` | | |||
There was a problem hiding this comment.
Can you add what is the default? If it is present by default do we need to add this param just to disable it?
There was a problem hiding this comment.
The default is 1G that comes pre-configured in opensearch.yml that should not be disabled. Will add it in the README
Signed-off-by: Rishabh Singh <sngri@amazon.com>
gaiksaya
approved these changes
May 3, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-23-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d3b12a8774835f1a6fdf41d2ea00b8e9fb7f8b8e
# Push it to GitHub
git push --set-upstream origin backport/backport-23-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.xThen, create a pull request where the |
rishabh6788
added a commit
that referenced
this pull request
Oct 24, 2023
Signed-off-by: Rishabh Singh <sngri@amazon.com> (cherry picked from commit d3b12a8)
rishabh6788
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds option to use 50 percent memory as heap. This change is in-line with recommended best practice of using 50% memory as heap and not to exceed 32G. This is an optional flag which means if not explicitly set the OS process would use the default 1G heap size.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.