Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated GitHub upload artifact action version #1886

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix deprecated GitHub upload artifact action version #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c32f9f
update 2.11 release notes
YANG-DB Oct 12, 2023
7ec595e
fix deprecated version of `actions/upload-artifact: v1`
YANG-DB Dec 3, 2024
ab57a2d
fix deprecated version of `actions/upload-artifact: v1`
YANG-DB Dec 3, 2024
2bfec2e
fix deprecated version of github actions
YANG-DB Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .github/workflows/opensearch-observability-test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,23 @@ jobs:
# using the same image which is used by opensearch-build team to build the OpenSearch Distribution
# this image tag is subject to change as more dependencies and updates will arrive over time
image: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-version-linux }}
# need to switch to root so that github actions can install runner binary on container without permission issues.
options: --user root
options: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-start-options }}

env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Comment on lines 25 to 26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section can be entirely removed as it is already deprecated by github.


steps:
- uses: actions/checkout@v1
- name: Run start commands
run: ${{ needs.Get-CI-Image-Tag.outputs.ci-image-start-command }}

- uses: actions/checkout@v4

- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java }}

distribution: 'temurin'

- name: Run Backwards Compatibility Tests
run: |
echo "Running backwards compatibility tests ..."
Expand All @@ -58,7 +61,7 @@ jobs:
cp -r ./build/distributions/*.zip opensearch-observability-builds/

- name: Upload Artifacts
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v3-node20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use v4, as v3 has been deprecated for now.

with:
name: opensearch-observability-ubuntu-latest
path: opensearch-observability-builds
Expand All @@ -73,13 +76,14 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4

- name: Set up JDK ${{ matrix.java }}
uses: actions/setup-java@v1
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: ${{ matrix.java }}

- name: Build with Gradle
run: |
./gradlew build
Expand All @@ -90,7 +94,7 @@ jobs:
cp -r ./build/distributions/*.zip opensearch-observability-builds/

- name: Upload Artifacts
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v3-node20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

with:
name: opensearch-observability-${{ matrix.os }}
path: opensearch-observability-builds
10 changes: 10 additions & 0 deletions release-notes/opensearch-observability.release-notes-2.11.0.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## Version 2.11.0.0 Release Notes

Compatible with OpenSearch 2.11.0

### Maintenance
- Updates demo certs used in integ tests ([#1626](https://github.com/opensearch-project/observability/pull/1626))

---

Full Changelog: https://github.com/opensearch-project/observability/compare/2.11...2.3
Loading