[Draft]: Graceful decommission support #4082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…er and BusyMasterServiceDisruption (opensearch-project#4058) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR opensearch-project#4051, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Upgrading dependencies for hadoop and aws-java-sdk Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing precommit Signed-off-by: Vacha Shah <vachshah@amazon.com> * Upgrading transitive dependencies Signed-off-by: Vacha Shah <vachshah@amazon.com> * Excluding transitive dependencies Signed-off-by: Vacha Shah <vachshah@amazon.com>
Bumps com.diffplug.spotless from 6.8.0 to 6.9.0. --- updated-dependencies: - dependency-name: com.diffplug.spotless dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pensearch-project#4019) * Bump protobuf-java from 3.21.2 to 3.21.4 in /plugins/repository-hdfs Bumps [protobuf-java](https://github.com/protocolbuffers/protobuf) from 3.21.2 to 3.21.4. - [Release notes](https://github.com/protocolbuffers/protobuf/releases) - [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/generate_changelog.py) - [Commits](protocolbuffers/protobuf@v3.21.2...v3.21.4) --- updated-dependencies: - dependency-name: com.google.protobuf:protobuf-java dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
…ject#4054) Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
pranikum
changed the title
pranikum
commented
Aug 2, 2022
|
|
||
| private void delay(long delayMillis) { | ||
| try { | ||
| Thread.sleep(delayMillis); |
There was a problem hiding this comment.
Will look into removing Thead.sleep call as per the comment
Gradle Check (Jenkins) Run Completed with:
|
5 tasks
Signed-off-by: pranikum <109206473+pranikum@users.noreply.github.com>
Gradle Check (Jenkins) Run Completed with:
|
|
@pranikum @Bukhtawar this PR has been there as draft for 300+ days? any plans to productionalize it? |
|
Closing the PR since we have take care as part of another PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for Graceful Node decommission.
This PR is on top of Node decommission PR. And has changes for handling graceful decommission.
When request for node decommission is received we will check the HTTP stats for the nodes being decommissioned. If the decommissioned nodes have active http request open we will wait for these active requests to be completed.
The real change related to graceful decommission is in.
https://github.com/opensearch-project/OpenSearch/pull/4082/files#diff-849967a77ed9b839e5b6de9ef959bf8c01dbb3dcb139813dab7c093e8ac0b0c2
Rest are taken from Dependent PR
Depends On: #3920
Issues Resolved
3956
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.