Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 2_19_1 for serialization of execution_hint in CardinalityAggregationBuilder #17492

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Feb 28, 2025

Description

This new option was introduced in 2.19.1 and the serialization on main needs to be updated to resolve bwc failures.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…nalityAggregationBuilder

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Update version to 2_19_1 for serialization of execution hint in CardinalityAggregationBuilder Update version to 2_19_1 for serialization of execution_hint in CardinalityAggregationBuilder Feb 28, 2025
Copy link
Contributor

❌ Gradle check result for 751026f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

FYI @asimmahmood1

@asimmahmood1
Copy link
Contributor

asimmahmood1 commented Feb 28, 2025

FYI @asimmahmood1

Yes, it was on my list to do, thanks @cwperks !

Ah, this started breaking because 2.x was merged in yesterday, which is what bwc is testing against.

2.19.1 was merged earlier but it is patch I guess we don't test against it, it didn't break main.

@cwperks
Copy link
Member Author

cwperks commented Feb 28, 2025

Ah, this started breaking because 2.x was merged in yesterday, which is what bwc is testing against.

2.19.1 was merged earlier but it is patch I guess we don't test against it, it didn't break main.

I merged the backport 2.x PR in after noticing that bwc tests were breaking between 2.x and 2.19 branch and then that caused bwc issues between main and 2.x 😅 . In general, there are short periods where bwc can break on the CI if a PR has changed serialization and the backports were not yet completed.

Copy link
Contributor

✅ Gradle check result for 751026f: SUCCESS

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (0ffed5e) to head (751026f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...gations/metrics/CardinalityAggregationBuilder.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17492      +/-   ##
============================================
- Coverage     72.42%   72.34%   -0.08%     
+ Complexity    65611    65580      -31     
============================================
  Files          5304     5306       +2     
  Lines        304743   304594     -149     
  Branches      44189    44163      -26     
============================================
- Hits         220701   220363     -338     
- Misses        65888    66149     +261     
+ Partials      18154    18082      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks cwperks merged commit 968eafb into opensearch-project:main Feb 28, 2025
55 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants