Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Bump commons-codec from 1.13->1.14 #17470

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

atl-dyon
Copy link

Description

Bumps commons-codec to address snyk issue SNYK-JAVA-COMMONSCODEC-561518

Check List

  • Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Dyon Georgopoulos <dgeorgopoulos@atlassian.com>
Copy link
Contributor

❌ Gradle check result for 73dc89d: ABORTED

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 0801816: SUCCESS

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (05f4aac) to head (0801816).
Report is 48 commits behind head on 1.3.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.3   #17470      +/-   ##
============================================
+ Coverage     77.56%   77.66%   +0.09%     
- Complexity    58760    58809      +49     
============================================
  Files          4223     4223              
  Lines        253441   253446       +5     
  Branches      38701    38701              
============================================
+ Hits         196590   196832     +242     
+ Misses        40844    40644     -200     
+ Partials      16007    15970      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks
Copy link
Member

cwperks commented Feb 27, 2025

@atl-dyon could you please add an entry to the CHANGELOG?

I see this is targeted at the 1.3 branch.

@cwperks cwperks changed the title Bump commons-codec from 1.13->1.14 [1.3] Bump commons-codec from 1.13->1.14 Feb 27, 2025
@cwperks
Copy link
Member

cwperks commented Feb 27, 2025

I don't see any more 1.3 releases scheduled on calendar. In order to consume this change, you would need to create a distribution from source.

@andrross andrross merged commit f1b5e67 into opensearch-project:1.3 Feb 27, 2025
19 checks passed
@atl-dyon
Copy link
Author

atl-dyon commented Feb 27, 2025

you would need to create a distribution from source.

@cwperks do you have a guide for that?

@cwperks
Copy link
Member

cwperks commented Feb 27, 2025

@cwperks do you have a guide for that?

For the core repo you can build from source using ./gradlew localDistro which builds a distribution specifically for the machine you are building on.

This would just be the core repo and modules. You would then also need to separately install any additional plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants