-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Offset management, support rewind by offset or timestamp #17354
Conversation
34a9a0b
to
7c573c3
Compare
❌ Gradle check result for 7c573c3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand the index level settings are controlling the offset resets. I am assuming that we expect this to work in a single shard and single partition setup
plugins/ingestion-kafka/src/main/java/org/opensearch/plugin/kafka/KafkaPartitionConsumer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/IndexMetadata.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/cluster/metadata/IngestionSource.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/IngestionShardConsumer.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/indices/pollingingest/DefaultStreamPoller.java
Outdated
Show resolved
Hide resolved
plugins/ingestion-kafka/src/main/java/org/opensearch/plugin/kafka/KafkaSourceConfig.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/IngestionShardConsumer.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/indices/pollingingest/DefaultStreamPollerTests.java
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 4a83c12: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 54c8bbe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 9dd5bd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Looks good to me |
❌ Gradle check result for 9dd5bd0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: xuxiong1 <xiongxug@outlook.com>
Signed-off-by: xuxiong1 <xiongxug@outlook.com>
Signed-off-by: xuxiong1 <xiongxug@outlook.com>
Signed-off-by: xuxiong1 <xiongxug@outlook.com>
Signed-off-by: xuxiong1 <xiongxug@outlook.com>
9dd5bd0
to
c76a342
Compare
❌ Gradle check result for c76a342: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c76a342: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: xuxiong1 <xiongxug@outlook.com>
❌ Gradle check result for 3d35f46: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17354 +/- ##
============================================
- Coverage 72.48% 72.46% -0.03%
- Complexity 65637 65672 +35
============================================
Files 5303 5303
Lines 304793 304858 +65
Branches 44202 44217 +15
============================================
- Hits 220926 220907 -19
- Misses 65711 65794 +83
- Partials 18156 18157 +1 ☔ View full report in Codecov by Sentry. |
Description
This PR supports starting the ingestion from a user-specified timestamp or offset when creating the new index.
REWIND_BY_OFFSET
andREWIND_BY_TIMESTAMP
ingestion_source.pointer.init.reset.value
toIndexMetadata
, controls the rewind offset or timestamp in millisRelated Issues
Resolves #17318
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.