Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query changes to support unsigned-long in star tree #17275

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add query changes to support unsigned-long in star tree #17275

wants to merge 2 commits into from
+260 −45

Conversation

Shailesh-Kumar-Singh
Copy link
Contributor

Description

Parent issue - [Star tree] Handle 'unsigned long' as part of star tree #15231
Handle unsigned long in search operations in star tree.

Related Issues
[Star tree] Handle 'unsigned long' as part of star tree #15231
[Star Tree ] Handle unsigned long during flush and merge operations #16645

This PR along with Indexing PR together resolves #15231

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Feb 6, 2025
add query changes to support unsigned-long in star tree
5c9fee9 
Signed-off-by: Shailesh Singh <shaikumm@amazon.com>
@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/unsigned-long-star-tree branch from 1545244 to 5c9fee9 Compare February 6, 2025 13:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

❌ Gradle check result for 5c9fee9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

address comments
128f2dd 
Signed-off-by: Shailesh Singh <shaikumm@amazon.com>
@Shailesh-Kumar-Singh Shailesh-Kumar-Singh force-pushed the feature/unsigned-long-star-tree branch from 826d5e3 to 128f2dd Compare February 21, 2025 08:59
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 128f2dd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Shailesh-Kumar-Singh Shailesh-Kumar-Singh mentioned this pull request Mar 1, 2025
Open
1 task
expani
expani reviewed Mar 1, 2025
View reviewed changes
...nsearch/index/compositeindex/datacube/startree/fileformats/node/FixedLengthStarTreeNode.java
resultStarTreeNode = binarySearchChild(
dimensionValue,
lastMatchedChild,
dimensionFilterMapper == null ? DimensionDataType.LONG::compare : dimensionFilterMapper.comparator()
Copy link
Contributor

@expani expani Mar 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this had to be done because we are yet to clean up

default StarTreeNode getChildForDimensionValue(Long dimensionValue) throws IOException {

which is only used in Unit tests for ST Indexing.

Let's pass DimensionDataType.LONG::compare from StarTreeNode for the time being to avoid putting the logic of figuring out the right comparator here ( since it's independent of the format of star tree index )

expani
expani reviewed Mar 1, 2025
View reviewed changes
...r/src/main/java/org/opensearch/index/compositeindex/datacube/startree/node/StarTreeNode.java
@@ -109,26 +110,30 @@ public interface StarTreeNode {
* @throws IOException if an I/O error occurs while retrieving the child node
*/
default StarTreeNode getChildForDimensionValue(Long dimensionValue) throws IOException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a TODO to remove this method.

Only used in UTs for Star Tree indexing.

expani
expani reviewed Mar 1, 2025
View reviewed changes
...r/src/main/java/org/opensearch/index/compositeindex/datacube/startree/node/StarTreeNode.java
@@ -109,26 +110,30 @@ public interface StarTreeNode {
* @throws IOException if an I/O error occurs while retrieving the child node
*/
default StarTreeNode getChildForDimensionValue(Long dimensionValue) throws IOException {
return getChildForDimensionValue(dimensionValue, null);
return getChildForDimensionValue(dimensionValue, null, null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets pass DimensionDataType.LONG::compare here for the time being.

Once, we remove this method it would all go away together.

@expani
Copy link
Contributor

expani commented Mar 1, 2025 •
edited
Loading

Thanks for the work on this PR and your patience in addressing comments. @Shailesh-Kumar-Singh
Really like how the new field type is integrated.
FYI @sandeshkr419 as you are also integrating date and IP types.

Just left a minor comment, rest looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharath-techie bharath-techie bharath-techie left review comments

@expani expani expani left review comments

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Star tree] Handle 'unsigned long' as part of star tree
3 participants
@Shailesh-Kumar-Singh @expani @bharath-techie