-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Star Tree] [Search] Resolving Range aggregations with Star-tree #17273
base: main
Are you sure you want to change the base?
Conversation
❌ Gradle check result for 4e15156: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sharing some benchmarking results with Range Aggregation with a sub-metric aggregation: Request:
Default (un-optimized code flow):
Star Tree Optimized:
Since there is a pre-compute optimization in place already, so benchmarking its performance over star-tree as well: Request:
Non-star Tree Optimization (filter rewrite):
Star Tree Optimization:
Based on the pereformance numbers, keeping the already non-star-tree pre-computation on higher priority over star-tree pre-computation. |
❌ Gradle check result for 2b4bfab: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 549d737: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2dda9b3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6b38984: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 6b38984: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Description
Resolving numeric range aggregation queries via star-tree.
Supporting numeric range aggregations with/without metric sub-aggregations.
Temp Notes
This PR contains unmerged changes keywords aggregation PR from as well. Kindly only look into range aggs last commit changes commit while reviewing the changes for now.(Depending changes merged)
Related Issues
Resolves #16553
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.