Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing append only setting for star-tree index #17180

Merged

Conversation

bharath-techie
Copy link
Contributor

Description

Enforcing append only setting for star tree index

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bharath-techie <bharath78910@gmail.com>
Copy link
Contributor

✅ Gradle check result for 9385529: SUCCESS

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (7306905) to head (9385529).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/opensearch/index/mapper/ObjectMapper.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17180      +/-   ##
============================================
+ Coverage     72.36%   72.38%   +0.02%     
+ Complexity    65606    65591      -15     
============================================
  Files          5306     5306              
  Lines        304923   304927       +4     
  Branches      44256    44257       +1     
============================================
+ Hits         220665   220734      +69     
- Misses        66151    66153       +2     
+ Partials      18107    18040      -67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit b2ee0e3 into opensearch-project:main Jan 29, 2025
37 of 39 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17180-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b2ee0e325f0fefad1c5b29eb93619b3af8b4d27b
# Push it to GitHub
git push --set-upstream origin backport/backport-17180-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-17180-to-2.x.

bharath-techie added a commit to bharath-techie/OpenSearch that referenced this pull request Jan 29, 2025
…#17180)

Signed-off-by: bharath-techie <bharath78910@gmail.com>
ashking94 pushed a commit that referenced this pull request Jan 29, 2025
Signed-off-by: bharath-techie <bharath78910@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants