Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isBase64encoded for external rewrites #698

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

conico974
Copy link
Contributor

Should fix #697

Copy link

changeset-bot bot commented Jan 13, 2025

🦋 Changeset detected

Latest commit: 1310fae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jan 13, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@698

commit: 1310fae

@sommeeeer
Copy link
Contributor

Tested this on a deploy and it works!

@conico974 conico974 force-pushed the fix/binary-rewrites branch from 26164c4 to 1310fae Compare January 17, 2025 13:53
@conico974 conico974 merged commit d1cea56 into opennextjs:main Jan 17, 2025
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding issue on binary data when using rewrites in AWS
3 participants