Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import correct logger #675

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: import correct logger #675

merged 2 commits into from
Dec 12, 2024

Conversation

sommeeeer
Copy link
Contributor

@sommeeeer sommeeeer commented Dec 12, 2024

There was an user in our Discord that complained about his lambda were outputting tons of logging, but he didn't have OPEN_NEXT_DEBUG set to any truthy value. Turns out that the node.ts module from the proxyExternalRequest override imported debug, and error from node:console instead of our own in adapters/logger.

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 78f6417

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@675

commit: 78f6417

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@conico974 conico974 merged commit 697681b into opennextjs:main Dec 12, 2024
3 checks passed
@sommeeeer sommeeeer deleted the fix-log branch December 12, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants