Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: partially reverts 644 #660

Merged
merged 4 commits into from
Dec 3, 2024
Merged

fix: partially reverts 644 #660

merged 4 commits into from
Dec 3, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 2, 2024

No description provided.

Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 979ea33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.91% 1723 / 7519
🔵 Statements 22.91% 1723 / 7519
🔵 Functions 56.59% 103 / 182
🔵 Branches 71% 436 / 614
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/adapters/middleware.ts 0% 0% 0% 0% 1-99
packages/open-next/src/core/requestHandler.ts 0% 0% 0% 0% 1-239
packages/open-next/src/core/routingHandler.ts 0% 0% 0% 0% 1-238
packages/open-next/src/core/routing/middleware.ts 96.89% 85.29% 50% 96.89% 34-37, 120
packages/open-next/src/overrides/converters/aws-cloudfront.ts 77.45% 80.76% 100% 77.45% 103-106, 151-191
packages/open-next/src/overrides/converters/edge.ts 0% 0% 0% 0% 1-113
packages/open-next/src/overrides/wrappers/cloudflare-edge.ts 0% 100% 100% 0% 8-70
packages/open-next/src/types/open-next.ts 0% 0% 0% 0%
Generated in workflow #802 for commit 979ea33 by the Vitest Coverage Report Action

Copy link

pkg-pr-new bot commented Dec 2, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@660

commit: 979ea33

@vicb
Copy link
Contributor Author

vicb commented Dec 2, 2024

Also doing some renaming, no strong opinion, open to anything better

@vicb vicb requested a review from conico974 December 3, 2024 06:28
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb requested a review from conico974 December 3, 2024 08:11
Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vicb
Copy link
Contributor Author

vicb commented Dec 3, 2024

fixed!
Thanks @conico974 for all the reviews this morning 🙏

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@vicb vicb merged commit 4dea7ea into main Dec 3, 2024
3 checks passed
@vicb vicb deleted the revert-644 branch December 3, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants