Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor overrides #579

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Conversation

conico974
Copy link
Contributor

@conico974 conico974 commented Oct 19, 2024

Fix #570
For review you probably want to look commit by commit

Copy link

changeset-bot bot commented Oct 19, 2024

🦋 Changeset detected

Latest commit: 8b31c4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Minor
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@579

commit: 54c48da

@conico974 conico974 force-pushed the chores/refacto-overrides branch from 6402f7d to b472368 Compare October 22, 2024 14:05
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Maybe move "added and fixed eslint rules for type import" in a separate PR to remove the noise from here?

@conico974
Copy link
Contributor Author

Looks good. Maybe move "added and fixed eslint rules for type import" in a separate PR to remove the noise from here?

@vicb That's probably a good idea yeah
I think this one ( along with #574 ) should be considered minor because they could break existing code. This one for custom overrides and the other one because it change the way to modify sharp install

@conico974 conico974 force-pushed the chores/refacto-overrides branch from b472368 to 10c39fb Compare October 22, 2024 18:16
conico974 and others added 3 commits October 22, 2024 20:18
Co-authored-by: Victor Berchet <victor@suumit.com>
@conico974 conico974 merged commit 5f661b5 into opennextjs:main Oct 22, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 22, 2024
@conico974
Copy link
Contributor Author

I've merged this one, but i'll stop the e2e test as they are broken at the moment.
I've run the e2e test on my account and it works

@conico974 conico974 deleted the chores/refacto-overrides branch October 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor overrides
2 participants