(feat) O3-4400 - render queue entry status in patient banner #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibongho
commented
Feb 20, 2025
| <div className={styles.queueEntryStatusContainer}> | ||
| <span className={styles.separator}>·</span> | ||
| <span>{queueEntry.queue.name}</span> | ||
| <Tag |
There was a problem hiding this comment.
This hard-coding of colors / text replacement is not great, but is taken from what we currently have in the patient chart.
3 tasks
chibongho
requested review from
mseaton,
denniskigen,
ibacher,
mogoodrich,
ojwanganto,
makombe and
donaldkibet
|
Size Change: -39.9 kB (-0.63%) Total Size: 6.28 MB
ℹ️ View Unchanged
|
mogoodrich
approved these changes
Feb 20, 2025
I don't believe they are used. |
denniskigen
reviewed
Feb 22, 2025
| // See: patient-banner-patient-info.component.tsx | ||
| interface PatientBannerQueueEntryStatusProps { | ||
| patientUuid: string; | ||
| renderedFrom: string; |
There was a problem hiding this comment.
We should probably type this renderedFrom more strictly. Maybe as a union type of possible values rather than a generic string.
There was a problem hiding this comment.
It is possible for any esm to render the patient banner component though, so I think it needs to be a free-form string.
Comment on lines
+43
to
+46
| const dispose = showModal('transition-queue-entry-modal', { | ||
| closeModal: () => dispose(), | ||
| queueEntry, | ||
| }); |
There was a problem hiding this comment.
nit: We should move this handler to a separate function within the component body.
NethmiRodrigo
added a commit
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
As part of the work to remove the custom visit header from the patient chart, we need to move the queue entry status indicator from the visit header to the patient banner.
See codependent PR in patient-chart: openmrs/openmrs-esm-patient-chart#2254
Note that this PR does not confirm to the mockup. It's only contains the work to move the functionality into the patient banner.
Screenshots
(The same stuff that's in the visit header will be removed in a separate PR)
Related Issue
Other