Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8290040: Provide simplified deterministic way to manage listeners #830
8290040: Provide simplified deterministic way to manage listeners #830
Changes from 1 commit
4c8453a
3485656
a70161c
fd19fc3
07e9d88
13c6e39
2353852
44d2ced
4fa45c7
ffba692
ea54699
46f206a
5c22fdd
67c277c
94b50b5
75ccca6
24872f0
7318af2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence sounds like
shownProperty()
is quite deeply connected to animations, which it isn't. Maybe you can clarify with "For example, ..."?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it reads really weird when I just make it an example (without putting a code example below it); I only added these to indicate possible use cases.
Perhaps if I rephrase it to "This property can also be useful to perform actions when the node is shown or no longer shown, like starting and stopping animations".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property probably should have been named
showing
to align it withWindow.showing
, but the "good name" is already taken byComboBox
and other controls. Just out of interest, have you considered alternatives toshown
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look too far for alternative names after I discovered
showing
would not be possible. The name comes fromisTreeShowing
which is used for a similar purpose (insideNode
) and fromconditionOnShowing
in ReactFX.The name needs to imply that visibility has no effect on it (ie,
setVisible(false)
won't toggle it). Neither does it check if the node isn't covered or off screen.In theory you could use a more general name (like
active
as in "part of an active currently showing scene graph").isActive
seems to even be available...A name like "used" or "inUse" may also work (as in "indicates the node is currently used as part of a currently showing scene graph".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That reminds me...
parent
is described as:Which I think is incorrect; parent can easily be non-null while not being part of a scene graph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayed
/displaying
?