8267551: Support loading images from inline data-URIs

[mstr2]

This PR adds support for loading images from inline data URIs, which is also widely supported by web browsers. This enables developers to package small images in CSS files, rather than separately deploying the images alongside the CSS file.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8267551: Support loading images from inline data-URIs

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jfx pull/508/head:pull/508
$ git checkout pull/508

Update a local copy of the PR:
$ git checkout pull/508
$ git pull https://git.openjdk.java.net/jfx pull/508/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 508

View PR using the GUI difftool:
$ git pr show -t 508

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jfx/pull/508.diff

[bridgekeeper]

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 18: Full - Incremental (8023fb81)
• 17: Full - Incremental (5cbfa701)
• 16: Full - Incremental (ed498ef6)
• 15: Full - Incremental (e490cc04)
• 14: Full - Incremental (29178487)
• 13: Full - Incremental (f6201b7e)
• 12: Full (315523c5)
• 11: Full - Incremental (d30f6109)
• 10: Full - Incremental (f6878f51)
• 09: Full - Incremental (edb6f658)
• 08: Full - Incremental (30211a4c)
• 07: Full - Incremental (d707615e)
• 06: Full - Incremental (907bc782)
• 05: Full - Incremental (4302e9f1)
• 04: Full - Incremental (3a77ac0b)
• 03: Full - Incremental (07ff1aa4)
• 02: Full - Incremental (71eb2d20)
• 01: Full - Incremental (e23ab085)
• 00: Full (4f273d0f)

[kevinrushforth]

/csr
/reviewers 2

[kevinrushforth]

I'd like to see this documented somewhere in the Image class docs.

[openjdk]

@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request.
@mstr2 please create a CSR request for issue JDK-8267551. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[openjdk]

@mstr2 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout feature/image-datauri
git fetch https://git.openjdk.java.net/jfx master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[kevinrushforth]

The docs updates look good, with a few minor comments.

[mstr2]

Since this implementation doesn't surface any new API, it will not prevent us from removing it at any future time when the "data" protocol might be supported by the JDK.

[kevinrushforth]

The docs look good. I left one minor comment inline.

You can update the CSR when ready. As I mentioned in a comment in the CSR, the Specification section should consist of the diffs to the API documentation. Make sure you note what API element (e.g., class doc, Image(String url) constructor, and so forth) each change is for, if it isn't clear from the diffs. You can omit the removal of the </p> html tags and the change from example. to example: from the diffs in the CSR.

[mstr2]

I've updated the CSR with the documentation diffs.

[kevinrushforth]

I reviewed and tested the implementation. I left a couple questions inline.

[mstr2]

Made changes as per review.

[kevinrushforth]

Looks good.

I reviewed the CSR, so you can move that to Finalized now.

[arapte]

Looks good to me too.

[openjdk]

@mstr2 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267551: Support loading images from inline data-URIs

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 98138c8: 8268219: hlsprogressbuffer should provide PTS after GStreamer update
• c81a722: 8264139: Suppress removal warnings for Security Manager methods
• 0ffa8e2: 8244075: Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene
• e6cf1df: 8267094: TreeCell: cancelEvent must return correct editing location
• ca25036: 8267858: Document that title property in WebEngine gets updated asynchronously
• 59cf4de: 8267505: {List,Set,Map}PropertyBase::bind should check against identity
• fe81b9c: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms
• ee03238: 8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams
• 47700d8: 8267819: CoInitialize/CoUninitialize should be called on same thread
• 526f990: 8239138: StyleManager should use a BufferedInputStream
• ... and 1 more: https://git.openjdk.java.net/jfx/compare/7b7050c46299c0e6771ae02fbb5ceaf22104d3e4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @arapte) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mstr2]

/integrate

[openjdk]

@mstr2
Your change (at version 8023fb8) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit 171e484.
Since your change was applied there have been 11 commits pushed to the master branch:

• 98138c8: 8268219: hlsprogressbuffer should provide PTS after GStreamer update
• c81a722: 8264139: Suppress removal warnings for Security Manager methods
• 0ffa8e2: 8244075: Accelerator of ContextMenu's MenuItem is not removed when ContextMenu is removed from Scene
• e6cf1df: 8267094: TreeCell: cancelEvent must return correct editing location
• ca25036: 8267858: Document that title property in WebEngine gets updated asynchronously
• 59cf4de: 8267505: {List,Set,Map}PropertyBase::bind should check against identity
• fe81b9c: 8268120: Allow hardware cursor to be used on Monocle-EGL platforms
• ee03238: 8268152: gstmpegaudioparse does not provides timestamps for HLS MP3 streams
• 47700d8: 8267819: CoInitialize/CoUninitialize should be called on same thread
• 526f990: 8239138: StyleManager should use a BufferedInputStream
• ... and 1 more: https://git.openjdk.java.net/jfx/compare/7b7050c46299c0e6771ae02fbb5ceaf22104d3e4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth @mstr2 Pushed as commit 171e484.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.