[samsungtv] Fix incorrect power state #17715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
lsiepel
approved these changes
Nov 7, 2024
jlaur
changed the title
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/samsung-tv-binding-beta/130551/1 |
KaaNee
pushed a commit
to KaaNee/openhab-addons
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Jan 2, 2025
Signed-off-by: Nick Waterton <n.waterton@outlook.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #17542
On some TV's, sending ON to turn the TV on, would result in the TV immediately turning OFF a few seconds later.
This was caused by the POJO which is used for decoding the json from the TV being changed to camelCase (don't know when this happened). Some of the json values are in UpperCamelCase though, so were not being decoded, specifically OS and PowerState.
This bug fix changes the POJO back to match the received json, and should resolve a number of similar issues.