Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename weight column #124

Merged
merged 1 commit into from
May 21, 2019
Merged

Rename weight column #124

merged 1 commit into from
May 21, 2019

Conversation

benjello
Copy link
Member

@benjello benjello commented May 21, 2019 •
edited
Loading

Technical changes

  • Rename weight_column_name to weight_variable_by_entity.

@benjello benjello requested review from Morendil and bonjourmauko May 21, 2019 10:09
@bonjourmauko bonjourmauko changed the title Fix #64 Rename weight_column_name_by_entity to weight_variable_by_entity May 21, 2019
@bonjourmauko bonjourmauko force-pushed the rename-weight-column-name branch 2 times, most recently from 29d7c9d to 6dc95ad Compare May 21, 2019 10:27
@bonjourmauko
Copy link
Member

Rebase et mis à jour

@benjello
[Fix #64] Rename weight column
6dc95ad 
Rename weight_column_name_by_entity to weight_variable_by_entity
@bonjourmauko bonjourmauko merged commit 1ca1d06 into master May 21, 2019
@bonjourmauko bonjourmauko deleted the rename-weight-column-name branch May 21, 2019 10:29
@bonjourmauko bonjourmauko changed the title Rename weight_column_name_by_entity to weight_variable_by_entity Rename weight column May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morendil Morendil Morendil approved these changes

@bonjourmauko bonjourmauko bonjourmauko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjello @bonjourmauko @Morendil