-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle parallel testing #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not enough convinced about why there is a need to implement this mechanism (node-index and nb-nodes) into the script, and about why there is a --nose
option.
Is it OK to tie the script to the CI needs?
I'm not criticizing the implementation; I just don't want to approve a code for which I don't understand the rationale :-)
fb475d4
to
dbfe0d9
Compare
Good point 👍 . I still need the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so I understand now!
The --nose
option runs the specified YAML tests using nose as a runner.
But couldn't we keep this option as the default and only one? When is it useful not to use this option?
Good question. The only drawback I see is that if running with I guess the second option is ok. |
a354f19
to
1bbafd3
Compare
1bbafd3
to
ed335fe
Compare
Connected to openfisca/openfisca-france#734
New features
nose
in theopenfisca-run-test
script