Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhancements to OpenTelemetry support #120

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

evansims
Copy link
Member

Description

This PR enhances the OpenTelemetry metrics reporting support released in 0.6.0:

  • Adds TelemetryConfiguration, TelemetryMetricsConfiguration and TelemetryMetricConfiguration classes.
  • Updates the Configuration class to accept a TelemetryConfiguration instance, for configuring what metrics and attributes will be used.
  • Adds unit tests for all OpenTelemetry functionality.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@evansims evansims added the enhancement New feature or request label Aug 28, 2024
@evansims evansims force-pushed the feat/support-opentelemetry-configuration branch 2 times, most recently from 5903699 to 8aec7cc Compare August 29, 2024 06:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 71.27072% with 104 lines in your changes missing coverage. Please review.

Project coverage is 69.14%. Comparing base (ced2963) to head (8a41825).

Files with missing lines Patch % Lines
openfga_sdk/api/open_fga_api.py 37.50% 40 Missing ⚠️
openfga_sdk/sync/open_fga_api.py 37.50% 40 Missing ⚠️
openfga_sdk/telemetry/metrics.py 75.00% 10 Missing ⚠️
openfga_sdk/telemetry/attributes.py 90.14% 7 Missing ⚠️
openfga_sdk/telemetry/configuration.py 93.26% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   68.72%   69.14%   +0.42%     
==========================================
  Files         120      121       +1     
  Lines        9772     9941     +169     
==========================================
+ Hits         6716     6874     +158     
- Misses       3056     3067      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evansims evansims force-pushed the feat/support-opentelemetry-configuration branch 3 times, most recently from 979ae4f to 5e7d521 Compare August 30, 2024 05:08
@evansims evansims marked this pull request as ready for review August 30, 2024 05:12
@evansims evansims requested a review from a team as a code owner August 30, 2024 05:12
@evansims evansims force-pushed the feat/support-opentelemetry-configuration branch from 5e7d521 to 8a41825 Compare August 30, 2024 19:31
@evansims evansims requested a review from rhamzeh August 30, 2024 19:31
@evansims evansims enabled auto-merge August 30, 2024 19:45
@evansims evansims added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit 33903ba Aug 30, 2024
17 checks passed
@evansims evansims deleted the feat/support-opentelemetry-configuration branch August 30, 2024 20:37
@evansims evansims mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants