Skip to content

fix: breaking change output of store import cmd #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Jun 25, 2024

Description

References

fixes #354

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris
Copy link
Member

@Siddhant-K-code, thanks for providing the PR! From testing as the progressbar still writes to stdout piping to jq still doesn't work.

What do you think about adding progressbar.OptionSetWriter(os.Stderr), to the options passed to progressbar.NewOptions. I think we're fine to pipe to stderr as it's deemed suitable for error messages and diagnostics. With that change the progress bar is displayed while importing tuples and I'm able to pipe to jq sucessfully

fga store import --file ./example/model.fga.yaml | jq  .store.id
"01J17BR1JA0G70FXMFFKMJ6ZRA"

@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Jun 25, 2024

@ewanharris, Just did that in 2d81b67, it should be fine now 🤞🏼

image

Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test locally and this looks good to me, thanks for the quick PR @Siddhant-K-code!

Pinging @rhamzeh for a second 👀

@Siddhant-K-code
Copy link
Member Author

Sure, and again sorry for that breaking change 🙈

@ewanharris ewanharris added this pull request to the merge queue Jun 25, 2024
Merged via the queue into openfga:main with commit 468164c Jun 25, 2024
13 checks passed
@Siddhant-K-code Siddhant-K-code deleted the fix/breaking-change-store-output branch June 25, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fga store create - breaking change v0.5
3 participants