This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated serde to version 1.0
project cleanup
@gavofyork, I know that's a part of #3380, but given your yesterday's message about repo split is it still a thing we want to do? |
We're going to split the repo? Hmm, then it seems this is worthless... I should've asked you first. Anyway I'll fix these issues in the next few days if we still want this. |
carry on for now. the refactoring will be a much bigger job and it's not clear at this point where the repo splits are best made. |
This pr hasn't been updated for > 28 days and I'm closing it as a part of pull request cleanup. If it's still relevant, please rebase and reopen it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
M4-core ⛓
Core client code / Rust.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3380 's first task.
I decided to keep the commit history, so the that's why you see there are some previous commits from @debris
The interesting commits from my side are:
I explicitly downgraded the
tiny-keccak
's version inethabi
. Because I tried to runcargo update
, but it hangs...I ran:
cargo build
andcargo test
./test.sh
All seems fine.