Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

integrate ethabi into parity repo #5758

Closed
wants to merge 118 commits into from

Conversation

guanqun
Copy link
Contributor

@guanqun guanqun commented Jun 4, 2017

Fixes #3380 's first task.

I decided to keep the commit history, so the that's why you see there are some previous commits from @debris

The interesting commits from my side are:

  • update the depedencies' path 57b1124
  • resolve the multiple workspace error b5b1814
  • downgrade tiny-keccak to 1.0 and its changes ac261ce
  • add ethabi-cli to parity 527ed6a
  • update Cargo.lock file c61f926

I explicitly downgraded the tiny-keccak's version in ethabi. Because I tried to run cargo update, but it hangs...

I ran:

  • cargo build and cargo test
  • ./test.sh
    All seems fine.

@debris
Copy link
Collaborator

debris commented Jun 4, 2017

@gavofyork, I know that's a part of #3380, but given your yesterday's message about repo split is it still a thing we want to do?

@debris debris added the A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. label Jun 4, 2017
@guanqun
Copy link
Contributor Author

guanqun commented Jun 4, 2017

We're going to split the repo? Hmm, then it seems this is worthless... I should've asked you first.

Anyway I'll fix these issues in the next few days if we still want this.

@gavofyork
Copy link
Contributor

carry on for now. the refactoring will be a much bigger job and it's not clear at this point where the repo splits are best made.

@rphmeier rphmeier added the M4-core ⛓ Core client code / Rust. label Jun 5, 2017
@gavofyork gavofyork added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Jul 13, 2017
@debris
Copy link
Collaborator

debris commented Aug 27, 2017

This pr hasn't been updated for > 28 days and I'm closing it as a part of pull request cleanup. If it's still relevant, please rebase and reopen it.

@debris debris closed this Aug 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate ethabi
5 participants