Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency typescript to v5 #4872

Merged
merged 7 commits into from
Sep 6, 2023

Conversation

edalex-yinzi
Copy link
Contributor

Checklist
Description of change

To fix #4870.

But note it has a warning:

 npm run check:ts

> check:ts
> eslint ${npm_package_config_typescript_glob}

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <5.2.0

YOUR TYPESCRIPT VERSION: 5.2.2

Please only submit bug reports when using the officially supported version.

=============

@edalex-yinzi
Copy link
Contributor Author

Hmm... stuck on the type issue:
image

@edalex-yinzi edalex-yinzi marked this pull request as draft August 31, 2023 06:38
@edalex-yinzi
Copy link
Contributor Author

edalex-yinzi commented Sep 1, 2023

I can't figure out the type for p. And seeing that its case is unusual compared to the official example, I will refactor the linkItem.

component definition:
image

@edalex-yinzi
Copy link
Contributor Author

And suppressImplicitAnyIndexErrors option is deprecated. Will see how builds go without it.

@edalex-yinzi edalex-yinzi marked this pull request as ready for review September 3, 2023 23:05
@edalex-ian
Copy link
Member

For the warning, did you check if there's an update for the typescript ESLint stuff?

@edalex-yinzi
Copy link
Contributor Author

For the warning, did you check if there's an update for the typescript ESLint stuff?

I didn't do much investigation on it because we are kind of stuck on eslint upgrade #4846

@edalex-yinzi
Copy link
Contributor Author

edalex-yinzi commented Sep 5, 2023

Now it looks the same: the first item is non-serverside, and the second item is serverside.

image

Copy link
Member

@edalex-ian edalex-ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's see if we can get a good build. 🤞

@edalex-ian edalex-ian merged commit 8211b8c into openequella:develop Sep 6, 2023
@edalex-yinzi edalex-yinzi deleted the fix/typescript-5.x branch September 11, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants