Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test!: Don't validate salesforce orgs against orgs.yml #15

Merged
merged 1 commit into from
Sep 22, 2022
Merged

test!: Don't validate salesforce orgs against orgs.yml #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,16 @@ Change Log

This project adheres to Semantic Versioning (https://semver.org/).

2022-09-22
~~~~~~~~~~

Changed
=======

* Don't validate orgs using orgs.yaml in the saleseforce export csv.



2020-08-07
~~~~~~~~~~

Expand Down
4 changes: 0 additions & 4 deletions repo_tools_data_schema/repo_tools_data_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,6 @@ def validate_salesforce_export(filename, encoding="cp1252"):
if acct == "Opfocus Test":
# A bogus entry made by the vendor. skip it.
continue
# "Individual Contributors" and "Household Accounts" are both Salesforce artifacts.
# In both cases, these records represent unaffiliated individual contributors.
acct_valid = (acct in ALL_ORGS or acct == "Individual Contributors" or acct.endswith(" Household"))
assert acct_valid, f"Account Name is not a valid org: {acct}"
username = row["GitHub Username"]
assert github_username(username), f"GitHub Username is not valid: {username}"

Expand Down