Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(multireplicasnapshot): remove multi replica snapshot checks in dataplane #1570

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat(multireplicasnapshot): remove multi replica snapshot checks in dataplane #1570

merged 1 commit into from
Jan 17, 2024

Conversation

hrudaya21
Copy link
Contributor

No description provided.

tiagolobocastro
tiagolobocastro reviewed Jan 8, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests as well

@hrudaya21 hrudaya21 force-pushed the feature/multi-replica-snapshot branch from 54ccfd9 to 7be240e Compare January 12, 2024 12:13
@hrudaya21
Copy link
Contributor Author

Let's add some tests as well

Added the test for multi-replica snapshot. Will more fault cases from control-plane BDD.

@hrudaya21 hrudaya21 force-pushed the feature/multi-replica-snapshot branch from 7be240e to ce0d371 Compare January 16, 2024 06:39
@tiagolobocastro
Copy link
Contributor

Let's add some tests as well

Added the test for multi-replica snapshot. Will more fault cases from control-plane BDD.

Depends on what type of fault cases, all paths should be tested in this repo only, it's not the control-plane's CI responsibility to find bugs in this repo..

tiagolobocastro
tiagolobocastro approved these changes Jan 16, 2024
View reviewed changes
@hrudaya21 hrudaya21 force-pushed the feature/multi-replica-snapshot branch from ce0d371 to 01c6025 Compare January 16, 2024 17:11
@hrudaya21
feat(multireplicasnapshot): remove multi replica snapshot checks
bdfbb67 
Signed-off-by: Hrudaya <hrudayaranjan.sahoo@datacore.com>
@hrudaya21 hrudaya21 force-pushed the feature/multi-replica-snapshot branch from 01c6025 to bdfbb67 Compare January 16, 2024 17:30
@hrudaya21
Copy link
Contributor Author

Let's add some tests as well

Added the test for multi-replica snapshot. Will more fault cases from control-plane BDD.

Depends on what type of fault cases, all paths should be tested in this repo only, it's not the control-plane's CI responsibility to find bugs in this repo..

I was indicating the cross node fault scenarios. As part of other review comments, cover error scenarios which can fail in dataplane explicitly.

@hrudaya21
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Jan 16, 2024
Try #1570:
4b09eb9
@bors-openebs-mayastor
Copy link

try

Build succeeded:

@hrudaya21
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 3623158 into openebs:develop Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@dsavitskiy dsavitskiy Awaiting requested review from dsavitskiy

@dsharma-dc dsharma-dc Awaiting requested review from dsharma-dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrudaya21 @tiagolobocastro @Abhinandan-Purkait