Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport fixes to release/2.7 #570

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Backport fixes to release/2.7 #570

merged 8 commits into from
Nov 27, 2024

Conversation

tiagolobocastro
Copy link
Contributor 

build: update controller dep

Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

feat(chart): add requestTimeout for core-agent container

Signed-off-by: Oleksandr Shalbanov <oleksandr.shalbanov.9@fntsoftware.com>

chore(bors): merge pull request #534

534: refactor: use controllerrevisions to filter data-plane Pods for upgrade r=niladrih a=niladrih

Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

fix(chart): allow scaling etcd via replicaCount and Helm upgrade

The etcd chart dynamically sets this value based on whether Helm is
installing or upgrading.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

chore(bors): merge pull request #529

529: feat(eventing): add error logs and retries for rest api requests r=niladrih a=niladrih

Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

chore: update docs URL in helm chart NOTES.txt

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>

chore(bors): merge pull request #517

517: Cherry-pick changes from mayastor PR r=tiagolobocastro a=tiagolobocastro

Cherry-pick user changes from stale mayastor PR.
Modified the initContainers change as we now have many init containers.

Co-authored-by: Joshua Carnes <jcarnes1@bellsouth.net>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>

mayastor-bors and others added 2 commits November 27, 2024 00:57
@jtcarnes @tiagolobocastro
chore(bors): merge pull request #517
bba4ed2 
517: Cherry-pick changes from mayastor PR r=tiagolobocastro a=tiagolobocastro

Cherry-pick user changes from stale mayastor PR.
Modified the initContainers change as we now have many init containers.

Co-authored-by: Joshua Carnes <jcarnes1@bellsouth.net>
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@niladrih @tiagolobocastro
chore: update docs URL in helm chart NOTES.txt
817a165 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
mayastor-bors and others added 5 commits November 27, 2024 01:04
@datacore-vvarakantham @niladrih @tiagolobocastro
chore(bors): merge pull request #529
65b6774 
529: feat(eventing): add error logs and retries for rest api requests r=niladrih a=niladrih

Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: mayastor-bors <mayastor-bors@noreply.github.com>
@michaelbeaumont @tiagolobocastro
fix(chart): allow scaling etcd via replicaCount and Helm upgrade
66764a8 
The etcd chart dynamically sets this value based on whether Helm is
installing or upgrading.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@niladrih @tiagolobocastro
chore(bors): merge pull request #534
e03f399 
534: refactor: use controllerrevisions to filter data-plane Pods for upgrade r=niladrih a=niladrih

Co-authored-by: Niladri Halder <niladri.halder26@gmail.com>
Signed-off-by: mayastor-bors <mayastor-bors@noreply.github.com>
@tiagolobocastro
feat(chart): add requestTimeout for core-agent container
5396c81 
Signed-off-by: Oleksandr Shalbanov <oleksandr.shalbanov@evry.com>
@tiagolobocastro
build: update controller dep
821c8cb 
Signed-off-by: Tiago Castro <tiagolobocastro@gmail.com>
@tiagolobocastro
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request Nov 27, 2024
Try #570:
c8a6a0f
@bors-openebs-mayastor
Copy link
Contributor

try

Build succeeded:

niladrih
niladrih requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains changes to upgrade, but it's incomplete. It's got half of the 'Upgrade enhancements changes'. Might be a good idea to go either way with this.

@niladrih
Copy link
Member

If you'd like to go all the way with the upgrade enhancements, you'd need this commit: fe6026a

@niladrih @tiagolobocastro
feat(upgrade): determine mayastor version from umbrella helm release …
14a93f0 
…data

Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@tiagolobocastro
Copy link
Contributor Author

If you'd like to go all the way with the upgrade enhancements, you'd need this commit: fe6026a

Done, PTAL

niladrih
niladrih approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niladrih
Copy link
Member

We might want to use localpv-provisioner v4.1.2 with release/2.7's helm chart.

@tiagolobocastro
Copy link
Contributor Author

We might want to use localpv-provisioner v4.1.2 with release/2.7's helm chart.

That's not a backport, please add that as separate PR.
bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit 6c67a93 into release/2.7 Nov 27, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the cherry-pick branch November 27, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@niladrih niladrih niladrih approved these changes

@sinhaashish sinhaashish Awaiting requested review from sinhaashish

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiagolobocastro @niladrih @Abhinandan-Purkait @michaelbeaumont