Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc_server: return correct instance of tokenizer #7

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented Apr 26, 2024

fixup to #4

Copy link

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dtrifiro, z103cb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@z103cb
Copy link

z103cb commented Apr 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 26, 2024
@dtrifiro dtrifiro merged commit 6baa1b8 into opendatahub-io:ibm_main Apr 26, 2024
1 check was pending
@dtrifiro dtrifiro deleted the fix-tokenizer-group branch April 26, 2024 14:39
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
Features integration:
Custom ops and kernels from private v0.2.7_dllehr
Triton attention kernel from jpvillam/v0.3.3_triton
Option to run multi GPU using torchrun instead or ray
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants