Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume #3689

antowaddle · 2025-01-28T12:34:58Z

https://issues.redhat.com/browse/RHOAIENG-17427

Description

Migrate 'Verifies users can create/delete a PersistentVolume' to Cypress ODS-1824
-This test focuses on PVC management through the user interface (UI). It encompasses the following key steps and verifications:

PVC Creation: Initiates the process by creating a new Persistent Volume Claim via the UI.
Dashboard Configuration Check: Verifies the PVC value in the dashboard configuration to ensure it matches the expected settings.
UI Consistency Verification: Compares the dashboard configuration PVC value with the corresponding value displayed on the UI, ensuring consistency across the system.
PVC Editing: Incorporates functionality to edit the existing PVC, allowing for testing of modification capabilities.
PVC Deletion: Concludes by deleting the created PVC, testing the complete lifecycle of a Persistent Volume Claim.

How Has This Been Tested?

An oc login should be performed in the cluster before running the test
test-variables.yml should be configured properly
Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
Locally against a PSI cluster and ODH-Nightly

Test Impact

None - this is a test

How to run?
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testClusterStorageCreation.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/clusterStorage/testClusterStorageCreation.cy.ts" --browser chrome

or Execute 'npx cypress run --env grepTags=@ODS-1824'

Request review criteria:

Self checklist (all need to be checked):

The developer has manually tested the changes and verified that the changes work
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

Included any necessary screenshots or gifs if it was a UI change.
Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

The developer has tested their solution on a cluster by using the image produced by the PR to main

increase card timeout and delete active wait

…e/odh-dashboard into cypress-RHOAIENG-14368

…comments

…ttps://github.com/antowaddle/odh-dashboard into cypress-RHOAIENG-12649

codecov · 2025-01-28T12:55:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (3167270) to head (2535e00).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3689      +/-   ##
==========================================
- Coverage   84.16%   84.14%   -0.03%     
==========================================
  Files        1453     1453              
  Lines       33865    33865              
  Branches     9384     9384              
==========================================
- Hits        28504    28496       -8     
- Misses       5361     5369       +8

see 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3167270...2535e00. Read the comment docs.

...ypress/cypress/tests/e2e/dataScienceProjects/clusterStorage/testClusterStorageCreation.cy.ts

ConorOM1 · 2025-01-28T14:21:56Z

@antowaddle maybe we could include editing also ? Or have we a separate test for this ?

ConorOM1 · 2025-01-28T14:25:14Z

the PR description mentions data connections ? This is for PV storage right ?

antowaddle · 2025-01-28T15:10:39Z

the PR description mentions data connections ? This is for PV storage right ?

@ConorOM1 Yes, good spot. Amended now.

… editing to the test

antowaddle · 2025-01-28T16:41:14Z

@antowaddle maybe we could include editing also ? Or have we a separate test for this ?

@ConorOM1 I'm not sure if we have a specific test case for this, but I've added it to this test.

ConorOM1 · 2025-01-28T17:01:35Z

nice work @antowaddle !

ConorOM1 · 2025-01-28T17:01:44Z

/lgtm

manosnoam

/lgtm

openshift-ci · 2025-01-29T10:07:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/src/tests/OWNERS~~ [manosnoam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…stent Volume (opendatahub-io#3689) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Committing completed test * Edited requested on pr - added backend check for PVC size, also added editing to the test --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>

antowaddle and others added 30 commits November 20, 2024 17:07

Initial WIP version of resource creation test

cacbfe5

Experimental changes to poll the UI for updates

0fa2201

Working version if resource is present

af87ad1

increase card timeout and delete active wait

0e9868a

Merge pull request #1 from FedeAlonso/fix/active_wait

429f086

increase card timeout and delete active wait

Added changes to find namespace from variables

443e530

Final changes to read variables, cleaned up utils

966917f

Merge branch 'main' into cypress-RHOAIENG-14368

69db944

Small change to a comment

a9ecfa3

Dummy change to trigger mocks

6cd6a3e

Merge branch 'opendatahub-io:main' into main

fcc6d18

Merge branch 'main' into cypress-RHOAIENG-14368

c7d471a

Save changes on cypress-RHOAIENG-12649

7628316

Changed file directories and names as requested on a PR comment

847ad11

Merge branch 'main' into cypress-RHOAIENG-14368

552a516

Merge branch 'cypress-RHOAIENG-14368' of https://github.com/antowaddl…

80cc894

…e/odh-dashboard into cypress-RHOAIENG-14368

Merge remote-tracking branch 'origin/main' into cypress-RHOAIENG-12649

163ed94

Saving changes to current branch

0f7eead

Additional directory/file name changes

48c7435

Additional changes to save

14a39de

Resolving timeout issue breaking mock tests, also resolved latest PR …

6a93ec2

…comments

Further changes for this test

31b9723

Changes to revert the exist method appended to getCardView.

f2b636d

Fixed linting

a9feb1b

Linting fixes

aa9430e

Merge branch 'main' into cypress-RHOAIENG-12649Merge branch 'main' of h…

eddd7d8

…ttps://github.com/antowaddle/odh-dashboard into cypress-RHOAIENG-12649

Final comments added

680a0ee

Merge branch 'main' into cypress-RHOAIENG-12649

b6bc5b3

Fixed merge conflict

781e952

Small change to page object name

b05b676

antowaddle added 6 commits January 20, 2025 16:34

Merge branch 'main' of github.com:opendatahub-io/odh-dashboard

cf25d91

Merge branch 'main' of github.com:opendatahub-io/odh-dashboard

b92780d

Merge branch 'main' of github.com:opendatahub-io/odh-dashboard

2036e59

Merge branch 'main' of github.com:opendatahub-io/odh-dashboard

69edb21

Merge branch 'main' of github.com:opendatahub-io/odh-dashboard

cebd375

Committing completed test

6f62a94

openshift-ci bot requested review from christianvogt and ppadti January 28, 2025 12:35

Merge branch 'main' into cypress-RHOAIENG-17427

1cec691

ConorOM1 reviewed Jan 28, 2025

View reviewed changes

...ypress/cypress/tests/e2e/dataScienceProjects/clusterStorage/testClusterStorageCreation.cy.ts Show resolved Hide resolved

Edited requested on pr - added backend check for PVC size, also added…

2535e00

… editing to the test

antowaddle requested a review from ConorOM1 January 28, 2025 16:41

antowaddle changed the title ~~Cypress e2e Test - Verifies users can create/delete a Persistent Volume~~ Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume Jan 28, 2025

openshift-ci bot assigned ConorOM1 Jan 28, 2025

openshift-ci bot added the lgtm label Jan 28, 2025

manosnoam approved these changes Jan 29, 2025

View reviewed changes

openshift-ci bot assigned manosnoam Jan 29, 2025

openshift-ci bot added the approved label Jan 29, 2025

openshift-merge-bot bot merged commit 2e6e823 into opendatahub-io:main Jan 29, 2025
29 checks passed

antowaddle deleted the cypress-RHOAIENG-17427 branch January 29, 2025 10:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume #3689

Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume #3689

antowaddle commented Jan 28, 2025 •

edited

Loading

codecov bot commented Jan 28, 2025 •

edited

Loading

ConorOM1 commented Jan 28, 2025

ConorOM1 commented Jan 28, 2025

antowaddle commented Jan 28, 2025

antowaddle commented Jan 28, 2025

ConorOM1 commented Jan 28, 2025

ConorOM1 commented Jan 28, 2025

manosnoam left a comment

openshift-ci bot commented Jan 29, 2025

Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume #3689

Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume #3689

Conversation

antowaddle commented Jan 28, 2025 • edited Loading

Description

How Has This Been Tested?

Test Impact

Request review criteria:

codecov bot commented Jan 28, 2025 • edited Loading

Codecov Report

ConorOM1 commented Jan 28, 2025

ConorOM1 commented Jan 28, 2025

antowaddle commented Jan 28, 2025

antowaddle commented Jan 28, 2025

ConorOM1 commented Jan 28, 2025

ConorOM1 commented Jan 28, 2025

manosnoam left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jan 29, 2025

antowaddle commented Jan 28, 2025 •

edited

Loading

codecov bot commented Jan 28, 2025 •

edited

Loading