Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cypress test folder owners #3659

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

manosnoam
Copy link
Contributor

@manosnoam manosnoam commented Jan 20, 2025

Description

We need to have approval ownership for the Cypress frontend tests

How Has This Been Tested?

N/A

Test Impact

A new OWNERS file under frontend/src/tests/

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

Signed-off-by: manosnoam <nmanos@redhat.com>
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antowaddle My spiderman quote every time we grant approval access... 🙂

With great power comes great responsibility. Be smart about your approvals and if ever in doubt reach out to the Advisors. PRs may need to be rebased to get the effect. GitHub Approvals grant the label, FYI.

If you approve something and don't see the lgtm and approval labels, feel free to reach out to me, we can debug what happened.

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrewballantyne
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 9e24946 into opendatahub-io:main Jan 20, 2025
27 checks passed
@manosnoam manosnoam deleted the cypress_owners branch January 21, 2025 07:26
ashley-o0o pushed a commit to ashley-o0o/odh-dashboard that referenced this pull request Feb 7, 2025
Signed-off-by: manosnoam <nmanos@redhat.com>
manaswinidas pushed a commit to manaswinidas/odh-dashboard that referenced this pull request Feb 24, 2025
Signed-off-by: manosnoam <nmanos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants