-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read and show default deployment mode in deploy modal #3651
Read and show default deployment mode in deploy modal #3651
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3651 +/- ##
==========================================
+ Coverage 84.06% 84.27% +0.20%
==========================================
Files 1432 1433 +1
Lines 33479 33500 +21
Branches 9279 9287 +8
==========================================
+ Hits 28144 28231 +87
+ Misses 5335 5269 -66
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Looks good, thank you @emilys314! |
/lgtm Tested with the image on @emilys314's cluster and the correct default was selected! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
797dd8f
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-16489
Description
Read the kserve
defaultDeploymentMode
value on the DSC status. Then use this value for preselecting the default mode and also show which one is the default.How Has This Been Tested?
This requires a nightly odh operator or the likes to have a default deployment mode other than serverless
disableKServeRaw
Test Impact
No tests added. the pulling of the DSC status value is pretty simple. and creating a cypress test for a different preselection seemed like overkill, but lmk.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
@yih-wang
After the PR is posted & before it merges:
main