Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error when importing v1 pipeline #3650

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Jan 16, 2025

JIRA: https://issues.redhat.com/browse/RHOAIENG-6754

Description

When importing a pipeline, do the following check:

  • Whether there is an InvalidInputError in the error message
  • Whether there is parsedYaml.kind === 'PipelineRun' && parsedYaml.apiVersion === 'tekton.dev/v1beta1' in the YAML file uploaded
    If true, then we change the error message to prompt user to the docs, and migrate their v1 pipelines to v2.
    NOTE: The docs are not available yet, it's for 2.17. So you will see 404 pages by clicking those links. But they are verified by the doc team.
Screenshot 2025-01-16 at 12 13 56 PM

How Has This Been Tested?

  1. Import a v1 pipeline (I added the example into the cypress test, you can find it in the code changes)
  2. Make sure you got the error message with links to the docs

Test Impact

Added cypress tests to verify this change

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode
Copy link
Member Author

@yannnz Could you review the screenshot? I changed the View documentation button to 2 link buttons because there will be 2 docs for self-managed services and cloud services. They share the same link with the argo error, so I just reused them.

@Gkrumbach07
Copy link
Member

this looks good

/lgtm

we can wait for UX

@Gkrumbach07
Copy link
Member

@DaoDaoNoCode going to merge this now, no UX feedback yet so no need to block this.

/approve

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9da072a into opendatahub-io:main Jan 21, 2025
27 checks passed
ashley-o0o pushed a commit to ashley-o0o/odh-dashboard that referenced this pull request Feb 7, 2025
manaswinidas pushed a commit to manaswinidas/odh-dashboard that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants