Add a media type to the image manifest #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The media type was excluded from the empty layer manifest intentionally. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
requested review from
dmcgowan,
jzelinskie,
jonjohnsonjr,
jdolitsky,
mikebrow,
stevvooe and
vbatts
as code owners
jdolitsky
approved these changes
Jul 3, 2023
jonjohnsonjr
approved these changes
Jul 6, 2023
mikebrow
reviewed
Jul 11, 2023
| @@ -14,6 +14,9 @@ type manifest struct { | |||
| // SchemaVersion is the image manifest schema that this image follows | |||
| SchemaVersion int `json:"schemaVersion"` | |||
|
|
|||
| // MediaType specifies the type of this document data structure e.g. `application/vnd.oci.image.manifest.v1+json` | |||
| MediaType string `json:"mediaType,omitempty"` | |||
There was a problem hiding this comment.
kk.. trying to remember if there was a good reason for us to have our own copy of these types vs importing them from the aligning image spec release
There was a problem hiding this comment.
I was asking the same thing recently. We are injecting a custom field in the descriptor where we can't just extend the struct in the test (since we would need to modify the manifests that include the descriptor). If we modified the tests to only extend the manifests with custom fields, this could become an import.
rchincha
pushed a commit
to rchincha/distribution-spec
that referenced
this pull request
Jul 11, 2023
The media type was excluded from the empty layer manifest intentionally. Signed-off-by: Brandon Mitchell <git@bmitch.net>
sudo-bmitch
added a commit
to sudo-bmitch/distribution-spec
that referenced
this pull request
Aug 18, 2023
The media type was excluded from the empty layer manifest intentionally. Signed-off-by: Brandon Mitchell <git@bmitch.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media type is recommended for manifests and required in descriptors.
The media type was excluded from the empty layer manifest intentionally to verify registries support clients that ignore the "SHOULD" in the image spec.
Fixes #435