Peru OEFA adapter #1085
Merged
Peru OEFA adapter #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 15, 2023 14:42
credentials need to be added to env as `SOURCE_NAME_CREDENTIALS`
caparker
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Could you
- update this to use our request client
- add docstrings
- change the parameters const at the top to follow the same pattern as what we are doing in the rwanda adapter. Use the object as a map to make sure we are getting the right units.
And dont hesitate to reach out if any of that is unclear or you just have questions.
|
@caparker I added docstrings and will update the documentation. I was having a hard time getting the client to work with the custom errors we have, so I left |
Also some util methods and guides
* set `active:false` all eea-direct adapters and South Africa * Set `active:false` for Bosnia_Tuslanski and Montenegro --------- Co-authored-by: Gabriel Fosse <kraken+majesticio@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peru OEFA fetch adapter. Added custom error if an incorrect user / or password is used, and some debug statements for empty responses. This is because all responses from the API return
status 200even if the wrong credentials are used. Waiting on source to confirm the dates are accurate before deploying as the measurements are all ~12+ hours old.