Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameters' units and updated adapter to overfetch to fill data gaps for Taiwan #1081

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

majesticio
Copy link
Contributor

To be merged and deployed after faulty new measurements and rollups have been deleted.

@majesticio majesticio requested a review from russbiggs February 9, 2024 20:31
@russbiggs
Copy link
Member

Based on the data gaps i was seeing, i'm not clear how an offset deployment would help. What is the behavior we see that necessitates an additional deployment? Can the same be achieved with overfetching in the main deployment?

We would want to have a clear case for an additional deployment, outlining what the pattern is and why the gaps appear.

@majesticio
Copy link
Contributor Author

I have looked at it some more and I think we can try to overfetch instead of using an extra deployment as the measurements endpoint is queryable by the hour historically, I can update the adapter to fetch the last 3 or 4 hours of measurments. this should resolve the data gaps issue.

@majesticio
Copy link
Contributor Author

majesticio commented Feb 16, 2024

I have updated the adapter to overfetch by 3 hours to address the data gaps. I removed the offset deployment as we are now relying on the over fetching strategy

@majesticio majesticio changed the title Fixed parameters' units and added offset deployment to fill data gaps for Taiwan data Fixed parameters' units and updated adapter to overfetch to fill data gaps for Taiwan Feb 16, 2024
@majesticio majesticio merged commit 101d071 into main Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants