add timeout configuration support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nunomaduro
reviewed
May 28, 2023
| return OpenAI::factory() | ||
| ->withApiKey($apiKey) | ||
| ->withOrganization($organization) | ||
| ->withHttpClient(new \GuzzleHttp\Client(['timeout' => config('openai.request_timeout', 30)])) |
There was a problem hiding this comment.
This is a breaking change?
There was a problem hiding this comment.
Yes, this is possibly a breaking change:
- If currently the requests are taking longer than 30 seconds
- If there are other HTTP clients installed, it's currently maybe not using the Guzzle Client (I think this one is unlikely and even if so, it should not change the behaviour)
But anyway I suggest to create a new major release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to configure the HTTP timeout via the
openai.phpconfiguration file.