-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support persisting SQLite DB, and data refresher #233
base: master
Are you sure you want to change the base?
Conversation
This reverts commit fa828f9.
@@ -336,3 +336,6 @@ ASALocalRun/ | |||
|
|||
# Fake database | |||
*fakedatabase.db | |||
|
|||
# Output path for app publishing | |||
/web-app-package/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this had accidentally entered the git repo at some point
@@ -0,0 +1,70 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is very similar to FakeDataRefresherService from #156, except with the following changes:
- Logs
- It informs DataRefresherStatusService when a has completed a cycle (which is explained in that file)
typeof(SellerUserTable) | ||
}; | ||
|
||
private static readonly Type[] TableTypesToDrop = new [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private static readonly Type[] TableTypesToDrop = new [] | |
// This is TableTypesToCreate in reverse order | |
private static readonly Type[] TableTypesToDrop = new [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent 30s wondering what was different between the two despite the comment below as I saw this first
This PR builds on top of the changes from this PR: #156. The main difference is this:
I did not quite have time to set up CI tests for this (though this has been partially complete). So, that has been put into another (wip) PR: #237
Possible goals for a later date, which are not being pursued here (they would need sufficient usecase (e.g. use at scale) to be worth pursuing in a future issue):
QA
Using the CI script from #237: