Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add i18n(zh-tw) support (and rename 'zh' as 'zh-CN') #290

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: add i18n(zh-tw) support (and rename 'zh' as 'zh-CN') #290

merged 1 commit into from
Dec 6, 2024
+242 −5

Conversation

eric1197
Copy link
Contributor

@eric1197 eric1197 commented Dec 6, 2024

Changes

  • Add new language option "繁體中文"
  • Change the original language code "zh" to "zh-CN"

Known Issue

  • The font family "Source Han Serif CN VF" does not support some texts in Traditional Chinese.

@OXeu OXeu self-requested a review December 6, 2024 05:40
@OXeu
Copy link
Collaborator

OXeu commented Dec 6, 2024

LGTM

@OXeu OXeu merged commit 9523a69 into openRin:main Dec 6, 2024
OXeu added a commit that referenced this pull request Dec 6, 2024
@OXeu
Revert "feat: add i18n(zh-tw) support (and rename 'zh' as 'zh-CN') (#290

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
3c5b688 
)"

This reverts commit 9523a69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OXeu OXeu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric1197 @OXeu