Skip to content

feat: Add adjacent feeds feature (Closes #202) #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from

Conversation

Sittymin
Copy link
Contributor

@Sittymin Sittymin commented Nov 28, 2024

变更内容

  • 在文章末尾添加了显示上下篇的功能
  • 加了根据前后缀获取和删除缓存的函数

未解决的问题

目前在列表中列出原先未列出文章时还不会更新缓存,只能手动删缓存

@Sittymin Sittymin marked this pull request as ready for review November 29, 2024 10:16
@OXeu OXeu self-requested a review November 30, 2024 11:00
@OXeu
Copy link
Collaborator

OXeu commented Nov 30, 2024

现在上一篇下一篇的宽度并没有固定,存在当只有一篇文章时占满
image
以及两篇文章宽度不一致的问题
image

@OXeu OXeu changed the base branch from main to dev November 30, 2024 16:10
@Sittymin
Copy link
Contributor Author

Sittymin commented Dec 1, 2024

只有一篇文章时,没有的那一边要加个啥占位吗?

@OXeu
Copy link
Collaborator

OXeu commented Dec 1, 2024

只有一篇文章时,没有的那一边要加个啥占位吗?

yes,最好一边占一半的宽度,不管有没有

@Sittymin
Copy link
Contributor Author

Sittymin commented Dec 1, 2024

奇怪。我部署我这分支怎么 Worker 直接503了(而且只有主要的 workers.dev 和自定义域受影响,预览版本没事)

@OXeu
Copy link
Collaborator

OXeu commented Dec 2, 2024

奇怪。我部署我这分支怎么 Worker 直接503了(而且只有主要的 workers.dev 和自定义域受影响,预览版本没事)

看日志貌似是超过 CPU 时钟限制了,可能是我最近合入的部分提交有问题,我晚点检查一下

@OXeu
Copy link
Collaborator

OXeu commented Dec 3, 2024

奇怪。我部署我这分支怎么 Worker 直接503了(而且只有主要的 workers.dev 和自定义域受影响,预览版本没事)

原因是 #268 中的代码字段名称与变量名称都是 where,导致运行时异常(可能是循环或其他问题)触发 cpu exceeded time,现 main 分支与 dev 分支已修
图片

@OXeu OXeu changed the base branch from dev-legacy to dev December 13, 2024 18:33
@OXeu
Copy link
Collaborator

OXeu commented Dec 13, 2024

提交比较脏,我清理了一下重提一个 pr #293

@OXeu OXeu closed this Dec 13, 2024
@OXeu OXeu removed their request for review December 14, 2024 06:02
@Sittymin Sittymin deleted the feature/adjacent-feeds-pr branch December 15, 2024 03:03
@OXeu OXeu mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants