Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:added credentials verification check #233

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

ivary43
Copy link

@ivary43 ivary43 commented Apr 3, 2018

Please make sure these boxes are checked before submitting your pull request - thanks!

Fixes #230

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@AkshGautam
Copy link
Contributor

AkshGautam commented Apr 3, 2018

@ivary43 Please refrain from duplicating the issue. A similar issue #227 was already created and I had started working on it by adding username checks.

@ivary43
Copy link
Author

ivary43 commented Apr 3, 2018

@AkshGautam I think this is not duplicate issue this is not only related to username length I added trimming, spaces check and password length check.I will remove that line containing username length you can add that.

@ivary43 ivary43 changed the title feat:added credentials verificaion layer feat:added credentials verificaion check Apr 3, 2018
@ivary43 ivary43 changed the title feat:added credentials verificaion check feat:added credentials verification check Apr 3, 2018
@AkshGautam
Copy link
Contributor

@ivary43 its fine, you can add that line too. It's not wise to make another PR by adding all the functions again and then resolve merge conflicts.You can add that to this PR itself. My bad that I did not explicitly explain the entire issue and started working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants