Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the .NET quickstart with working samples #1000

Merged

Conversation

cartermp
Copy link
Contributor

@cartermp cartermp commented Dec 21, 2021

This one's a total rewrite, but does re-use some concepts from the first one.

The existing doc has code that won't compile, and in general, is a bit heavy for getting started.

Instead, what I focused on was copy-pastable, modern .NET 6 (LTS release) samples. Concepts like acquiring a tracer (activitysource), starting a span (activity), wiring up an exporter, etc. can be covered in subsequent articles.

This would be considered a part of #1001

Preview: https://deploy-preview-1000--opentelemetry.netlify.app/docs/instrumentation/net/getting-started/

@cartermp cartermp requested a review from a team December 21, 2021 01:25
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few initial comments. See inline.

I'll let domain experts review this before doing a more complete read.

@austinlparker austinlparker merged commit f74523c into open-telemetry:main Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants