Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify async instrument callback identity #2538

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Clarify async instrument callback identity #2538

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dce9e46
Clarify async instrument callback identity
legendecas May 13, 2022
0051b11
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas May 20, 2022
f88f232
Merge branch 'main' into metric-callback
legendecas May 21, 2022
0184309
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas Jun 10, 2022
21e5fce
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas Jun 21, 2022
42d0725
fixup!
legendecas Jun 21, 2022
51b8d75
fixup!
legendecas Jun 21, 2022
2379e34
Merge remote-tracking branch 'upstream/main' into metric-callback
legendecas Jul 4, 2022
572aec4
Merge branch 'main' into metric-callback
jmacd Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup!
  • Loading branch information
@legendecas
legendecas committed Jun 21, 2022
commit 42d0725c5eab34d2581b9f9aa9aadeef8aaaea29
3 changes: 1 addition & 2 deletions specification/metrics/api.md
View file
Original file line number Diff line number Diff line change
@@ -364,8 +364,7 @@ registration of the specific callback after its registration by some means.

Every currently registered Callback associated with a set of instruments MUST
be evaluated exactly once during collection prior to reading data for
that set. The evaluation is identified using a combination of the
callback itself, and the instruments set.
that set.

Callback functions MUST be documented as follows for the end user: