Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update env variable values to match other env variables. #1965

Merged
merged 5 commits into from
Sep 28, 2021
Merged

Update env variable values to match other env variables. #1965

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e04b3c
Update env variable values to match other env variables in the specif…
jsuereth Sep 24, 2021
40b2a2d
Fixes from review.
jsuereth Sep 24, 2021
b39d443
Merge branch 'main' into wip-lower-case-env-variables
arminru Sep 27, 2021
53d6366
Merge branch 'main' into wip-lower-case-env-variables
jsuereth Sep 28, 2021
a6d94ce
Merge branch 'main' into wip-lower-case-env-variables
carlosalberto Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions specification/metrics/sdk.md
View file
Original file line number Diff line number Diff line change
@@ -754,15 +754,4 @@ modeled to interact with other components in the SDK:

## Defaults and Configuration

The SDK MUST provide the following configuration parameters for Exemplar
sampling:

| Name | Description | Default | Notes |
|-----------------|---------|-------------|---------|
| `OTEL_METRICS_EXEMPLAR_FILTER` | Filter for which measurements can become Exemplars. | `"WITH_SAMPLED_TRACE"` | |

Known values for `OTEL_METRICS_EXEMPLAR_FILTER` are:

- `"NONE"`: No measurements are eligble for exemplar sampling.
- `"ALL"`: All measurements are eligible for exemplar sampling.
- `"WITH_SAMPLED_TRACE"`: Only allow measurements with a sampled parent span in context.
The SDK MUST provide configuration according to the [SDK environment variables](../sdk-environment-variables.md) specification.
14 changes: 14 additions & 0 deletions specification/sdk-environment-variables.md
View file
Original file line number Diff line number Diff line change
@@ -178,6 +178,20 @@ Known values for OTEL_METRICS_EXPORTER are:
- `"prometheus"`: [Prometheus](https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md)
- `"none"`: No automatically configured exporter for metrics.

## Metrics SDK Configuration

**Status**: [Experimental](document-status.md)

| Name | Description | Default | Notes |
|-----------------|---------|-------------|---------|
| `OTEL_METRICS_EXEMPLAR_FILTER` | Filter for which measurements can become Exemplars. | `"with_sampled_trace"` | |

Known values for `OTEL_METRICS_EXEMPLAR_FILTER` are:

- `"none"`: No measurements are eligble for exemplar sampling.
- `"all"`: All measurements are eligible for exemplar sampling.
- `"with_sampled_trace"`: Only allow measurements with a sampled parent span in context.

## Language Specific Environment Variables

To ensure consistent naming across projects, this specification recommends that language specific environment variables are formed using the following convention: