Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Exemplars SDK Specification #1828

Merged
merged 14 commits into from
Aug 30, 2021
+130 −0
Merged

Metric Exemplars SDK Specification #1828

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7c83af6
First cut at exemplar spec.
jsuereth Jul 26, 2021
11eb9e1
Update exemplar specification.
jsuereth Aug 17, 2021
08a94ee
Merge branch 'main' into wip-exemplar
jsuereth Aug 17, 2021
1177b05
Merge branch 'main' into wip-exemplar
jsuereth Aug 25, 2021
2e6db06
Remove the word parent
jsuereth Aug 26, 2021
8a9b6a9
Update specification/metrics/sdk.md
jsuereth Aug 26, 2021
26b5957
Update specification/metrics/sdk.md
jsuereth Aug 26, 2021
09dd010
Update specification/metrics/sdk.md
jsuereth Aug 26, 2021
ff106f4
Update specification/metrics/sdk.md
jsuereth Aug 26, 2021
4c7e082
Update specification/metrics/sdk.md
jsuereth Aug 26, 2021
67e4ff6
Merge remote-tracking branch 'origin/main' into wip-exemplar
jsuereth Aug 27, 2021
b451a7b
Merge branch 'wip-exemplar' of https://github.com/jsuereth/openteleme…
jsuereth Aug 27, 2021
530859b
Fixes from review.
jsuereth Aug 27, 2021
a8ef58c
Clarify a confusing paragraph.
jsuereth Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update specification/metrics/sdk.md 
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@jsuereth @reyang
jsuereth and reyang authored Aug 26, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 8a9b6a96f5e513344324330d8a654d9d92792025
2 changes: 1 addition & 1 deletion specification/metrics/sdk.md
View file
Original file line number Diff line number Diff line change
@@ -477,7 +477,7 @@ The `ExemplarReservoir` SHOULD avoid allocations when sampling exemplars.

### Exemplar Defaults

The SDK will come with two types of built-in exemplar resorvoirs:
The SDK will come with two types of built-in exemplar reservoirs:

1. SimpleFixedSizeExemplarReservoir
2. AlignedHistogramBucketExemplarReservoir