Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about reporting dropped attributes/events/links #1699

Merged
merged 6 commits into from
May 19, 2021
Merged

add note about reporting dropped attributes/events/links #1699

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d347e9e
add note about reporting dropped attributes/events/links
May 13, 2021
191f92b
add link to sdk exporter spec
May 13, 2021
d15a948
update to rephrase that counts must be available to be reported
May 17, 2021
1bd0a71
Merge branch 'main' into add-note-about-dropped
May 18, 2021
3d9007e
Merge branch 'main' into add-note-about-dropped
carlosalberto May 19, 2021
78bb1ff
move change to readable span section
May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,10 @@ There SHOULD be a log emitted to indicate to the user that an attribute, event,
or link was discarded due to such a limit. To prevent excessive logging, the log
should not be emitted once per span, or per discarded attribute, event, or links.

Counts for attributes, events and links dropped due to collection limits MUST be reported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this MUST is too much, as it depends on the protocol. What we should say is that the counts MUST be available for exporters. I think this would best fit in the "readable span" wording, somewhere around https://github.com/open-telemetry/opentelemetry-specification/pull/1699/files#diff-ace73543d690260e873d774428419c23895283b6c31177d405816b154d1f5aa0R91

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Oberon00, I updated the note, PTAL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to move this wording to the "readable span" definition, somewhere around line 91, as this will probably be the part where this wording has to be implemented. But semantically, the change looks good to me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten Could you update this part according to @Oberon00 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

at export time as described in the [exporters](./sdk_exporters/non-otlp.md#dropped-attributes-count)
specification.

## Id Generators

The SDK MUST by default randomly generate both the `TraceId` and the `SpanId`.
Expand Down