Move binary propagator and base64 format to contrib. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved them as they are not part of the spec for now and should not be in main crate when GA. * Also restructure the contrib into two submodule, one for tracing and one for metric.
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
==========================================
- Coverage 54.03% 53.20% -0.84%
==========================================
Files 71 69 -2
Lines 5879 5770 -109
==========================================
- Hits 3177 3070 -107
+ Misses 2702 2700 -2
Continue to review full report at Codecov.
|
jtescher
approved these changes
Nov 5, 2020
jtescher
reviewed
Nov 5, 2020
examples/datadog/src/main.rs
Outdated
| @@ -17,7 +17,7 @@ fn bar() { | |||
| } | |||
|
|
|||
| fn main() -> Result<(), Box<dyn std::error::Error + Send + Sync + 'static>> { | |||
| let (tracer, _uninstall) = opentelemetry_contrib::datadog::new_pipeline() | |||
| let (tracer, _uninstall) = opentelemetry_contrib::trace::exporter::datadog::new_pipeline() | |||
There was a problem hiding this comment.
small nit: may want to use this as above? calling a function 4 namespaces deep currently 😂
There was a problem hiding this comment.
Yeah definitely should have imported them at the top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
binarymodule and reexport the public types.closes #336